Various search filters and user experience enhancers
< Feedback on PH - Search & UI Tweaks
Can you post a reference link please, so I can reproduce the issue?
I have the same issue as miwoj. ONLY on "view video" pages, for example:
https://www.pornhub.com/view_video.php?viewkey=ph5ef4f16d14ebd
The script blocks whatever you have selected (Premium, watched, sd videos, etc.), but after a little while, all of them appear again. If you open the UI and click "Apply", they are blocked one more time for good. But it's a little annoying, cos every time you jump to another video, you need to "Apply" again your preferences manually.
On any other page different from "View_video" (for example, playlists, your feed of videos, list of videos uploaded by some other user, recommended videos, etc.) the script works great and doesn't have the issue.
Also note that on pages that have a "Load more videos" button, for example the "Related videos" on right side of player, every time you load more videos, you need to click "Apply" again on the UI for the script to work. The same happens for example on your Feeds page (https://www.pornhub.com/feeds?section=videos), the page shows a certain quantity of videos and the script does automatically what it's expected to do. But then you need to click on "Load more", and the page shows several more videos. That "new videos" are not affected in any way by the script, until you manually open UI and click on "Apply" again.
I'm not an english speaker, so I apologize in advance for any mistakes. Anyway I expect you can understand what I described.
The script is fantastic, hopefully you can continue to maintain and improve it. Thank you very much.
Yes I know that discrepancy, I had mitigated it to an extent but just abandoned the effort midway. I'll look into it again the next time I get some time to spare.
I'm not programmer or anything, but in my humble opinion (just trying to help), what happens is the following:
-On any pornhub page that doesn't have the "Video Player", the page loading is immediate. The page loads and the script do its blocking a tenth of a second later, and everything looks great.
-But, on the contrary, when the pornhub page has the video player, it took a little longer to load. The script does its blocking, but the page finishes loading a fraction of a second later, and the blocked videos come back. It's just like the page finishes refreshing after the video is fully load. Once it did, you open the script UI, click "Apply" and the script works perfect again, but this time the blocked videos don't come back.
So, I think the trick should be like this: Only on the view-video pages, maybe you can apply a simple delay for the script to work. For example, 2 o 3 seconds later. That would give the page time to fully load the video and the rest of the stuff, and then the script would do its job. Maybe that can fix the problem.
Thanks again for your good work. As I said, this is an AMAZING script, and the only one working nowadays to modify pornhub. I hope you can correct the few issues it has.
I know exactly what is happening and as you described before there are many other areas on the site that have things coming later or come when either you press a button or go a certain way down a page.
This is called "lazy or infinite or paged loading" in our world. This can't really be solved by adding a delay to the script execution, not to mention this is not a good practice as different PCs will have arbitrary results.
It is done through a monitoring mechanism which needs to be attached to all such areas where such items appear at any point in time.
At first I was maintaining this but PH started to get very frequent changes and soon I lost motivation with all the back and forth changes. I have since matured this mechanism for my other works so once I am a bit free (weekend perhaps) I'll look into porting that for this script.
You're the boss. Look into it when you have time. I appreciate it and I'm very grateful.
Another suggestion: The same way the script blocks "watched videos", "sd videos", "pro channel videos", etc. is it possible to block "pornstar videos" also? I mean videos uploaded by pornstars (not models or users). Prevent them from appearing in playlists, in the sidebar of related videos, and anywhere else on the web. Like adding another category of blockable videos.
That would be awesome.
Thank you very much.
Well to be overly simple, I need some kind of visual difference in such video boxes from normal boxes to filter anything.
Frankly I would also love to filter such videos from my experience too but I haven't been able to figure out a tangible difference that is unique to such videos.
At maximum you can filter them out if their names are mentioned in the video name through blacklist.
The new version hides the new fan videos (through paid videos) and has better dynamic content handling.
Do reply, if it still does not work as intended for you.
Hey, thanks for taking care of it so soon.
I already installed the new version (1.15.0), I don't see any major differences in performance from the previous version. It blocks correctly the "Unlock with fan club" videos, but unless I am confused, I think the previous version also blocked them. Unfortunately the main problem with the script remains the same.
That is, the script works correctly in general, but in the view_video pages and in those that load new videos after some time (automatically when scrolling down or after the user clicks on "Load more"), it is necessary to open the UI and click on "Apply" again for the script to block all the necessary videos. In the view_video pages the same thing happens as I already told you in the previous posts, that is, the script blocks all the videos you selected, but after a small interval, all of them come back. If you open the UI and click "Apply" again, the script will block them for good.
Beyond that, I've been testing your script for many hours on different pornhub pages and I can give you a long feedback with some suggestions of things to improve.
1) The script is great and works flawlessly on every pornhub page I happened to try. With the sole exception of the issue I've just described above. Which also does not prevent the script from working, but it just involves making a couple more clicks.
2) It would be good and much more comfortable if the UI had an auto-hide when you remove your mouse from it, or at least by clicking anywhere on the page outside the UI, to avoid having to click especially on the "Hide" button.
3) The "settings-show" button is too big and visible for my taste, plus the "Search & tweaks" is written outside the button. I managed to make it a little smaller by deleting the title "Search & tweaks" from the code, but other than that I haven't been able to customize the size or color of that button. You can change the size and color of the main interface, I have seen that, but not the button. In my case, I had to resize the main interface so that all the items could be seen, but I don't know if that will happen the same in all computers.
As for the "settings-show" button, it’s correct that it’s always present on the left side of the screen, but from the moment you know it is there, it doesn't have to be so visible. For me, it would be better a thin, almost black line, that blends in with the background and goes unnoticed, doing its job without being seen. In case you want to open the interface, you know that the key is there and you will click it anyway. If it's ok for you as it is now, it would be nice if you told me what I should add to the code to modify the size and color of that button.
4) On the page "pornhub.com/users/*name of the user*/videos/favorites" which would be the list of the videos that the user marked as favorites, it would be better if the script didn't work, since it blocks all videos by "watched" and doesn't make much sense. It is logical that if the user marked them as favorites, it’s because he watched them. If at some point you go back to that page to look for a video you've already watched, you don't want the script to block them. In addition, in your favorite videos page there are no other related or suggested videos, so it’s very little what the script can do, besides block all your watched videos. In my case, I solved it by adding that url as "user exclude" in the script settings in Tampermonkey. But maybe it would be better if it was an "original exclude" because maybe other users won't notice that.
5) The blocklist and the sanitize work very well, I edited them adding and also deleting some of the words that are included by default in the code. In my humble opinion, it would be better if the code didn't have words included by default, because everyone's tastes are different. In my case, I deleted all the words in sanitize because I don't want the script to change words in the names of the videos. And in the blocklist I left some words, deleted others and added more. But again, every user will have different tastes.
6) In the main interface, at the end, there is the count of the amount of blocked videos of each type (low res, short, watched, etc), but it does not inform the amount of blocked videos of the items "Paid", "Private" and "Premium". I understand that maybe there is not enough room for all the items, but in my case I am more interested in those than for example in the "Short" "Low rated" and "By views" since I do not block any of them. I was going to touch the code to see if I could take ones out and put the others in, but I didn't have time to do that yet. And I'm not sure I can do it either, ha ha.
7) There’s an interesting customization that I saw in another script (that doesn't work anymore). I added it at the end of your code and it works very well. It replaces the links to a username or model's name with their video page. That is, for example, when you click on pornhub.com/model/*, the link goes automatically to pornhub.com/model/*/videos/upload. If it were a user instead, it would go directly to pornhub.com/users/*/videos/public. It's convenient and saves time. You could add it to your script. If you are interested, I can pass you the lines of code here. Anyway, it's very simple and I guess you'll know how to write it too.
So, that's my looooong feedback for now, I hope you can consider the things I'm suggesting.
I congratulate you again for the script, which is excellent and I hope you can continue to maintain and improve it.
@christian747
Make a new issue and leave this one as this only concerns the fan club videos (which were indeed handled before but changed to a new UI recently).
I cannot reproduce the issue you are facing with the load more thing. For me it works fine. It would be better if you can supply your settings in the script and also in local storage (If you are using it). Also mention your browser and any related links where it does not work.
I will make the settings dialog a slim line which will open the menu when hovered upon and close it when mouse goes out of the panel.
I don't intend to work that much on the UI to make it compatible with anything less than my screen. Frankly, I hate working on UIs and thus, that's as far as I am going with this. Unless, the heavens throws their wrath on me and I am forced to use my laptop as my main.
I'll exclude the favorites page from the script.
You have a point. I'll add those values as comments so users can see how they must be added.
You can do it by following the example of any of the tracked filters. It is quite easy actually, I think no more than 3-4 lines.
Yes, I have been irked to no end due to the extra clicks and waiting required for such. And Yes, I know how to go about it myself.
Hide Premium vids no longer works.
premium vids are now shown with a delay, after the script, so they are shown anyway. plz fix.