ExtendPornHub

Remove ads, enlarges video, stops autoplay keeping buffering & block pop-ups

< Feedback on ExtendPornHub

Review: OK - script works, but has bugs

§
Posted: 2015-07-30
Edited: 2015-07-30

Patch for video controls, Play/Pause etc.

Hey I just installed this and noticed the video controls weren't working unless I right clicked and selected play/pause so I took a look at the script and noticed on line 79 you had vid.play, vid.paused() etc and Can't see where to submit a patch or pull request so thought I'd mention it here.

Also I had to fully disable flash in firefox not just deny it on that page before the html5 player kicked in, anything that can be done about that?

So line 79 should change from this:
video.setAttribute("onclick", "var vid = event.target;if(vid.paused)vid.play();else vid.pause()")
to this:
video.setAttribute("onclick", "var vid = event.target;if(video.paused)video.play();else video.pause()")




Edit: On further investigation you are better off just deleting lines 79, 80 and 81 altogether. I have full play/pause, fullscreen/un-fullscreen, show statistics and play speed controls once they have been deleted. Pretty sure they are the default native controls and don't need to be changed.

jack_mustangAuthor
§
Posted: 2015-07-31

No, I can't delete those lines, those lines are 'necessary' for Chromium & WebKit browsers. For now I disabled it on Firefox.

Your previous change is also wrong, it's vid as in the beginning I'm defining vid as the event.target. The inline script is:

var vid = event.target;
if(vid.paused)
    vid.play();
else
    vid.pause()

Also I had to fully disable flash in firefox not just deny it on that page before the html5 player kicked in, anything that can be done about that?

Those stupid browsers, good old times of Opera when disabling flash on that page really disabled it. I don't know of any solution, if I can find a way to force PornHub to load it I'll create a script.

Post reply

Sign in to post a reply.